-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: fix errant tight_layout test #15671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why is it needed to remove this test? |
The test itself is incorrect because the More substantially, this bug was actually a bug in |
Ah, the reason that it is 2 instead of 3 is the reason it now just passes, while the test should actually fail because it needs >= 2.0.1 instead of >= 2.0.0 ? I think testing this in pandas is fine, as we should keep tight_layout working with pandas plots (we may change implementation details in the hist method that could cause problems with tight_layout) |
Yes, exactly. Hmm. OK, can do. |
Codecov Report
@@ Coverage Diff @@
## master #15671 +/- ##
==========================================
- Coverage 91.03% 91.01% -0.03%
==========================================
Files 143 143
Lines 49380 49386 +6
==========================================
- Hits 44953 44947 -6
- Misses 4427 4439 +12
Continue to review full report at Codecov.
|
@jreback @jorisvandenbossche Does this look good? Tests pass. |
This would close #9351. |
lgtm. @jorisvandenbossche |
Thanks! |
closes #9351